[coreboot-gerrit] Change in coreboot[master]: google/chromeec: Add support for I2C and SPI devices

Furquan Shaikh (Code Review) gerrit at coreboot.org
Wed Apr 26 18:19:41 CEST 2017


Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19464 )

Change subject: google/chromeec: Add support for I2C and SPI devices
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19464/1/src/ec/google/chromeec/acpi/cros_ec.asl
File src/ec/google/chromeec/acpi/cros_ec.asl:

Line 34: 		Name (_HID, "GOOG0008")
> We seem to have a conflict with our device ids: https://review.coreboot.org
I think its the same device using this _HID. Just that its being changed from i2c-hid to cros_ec?


-- 
To view, visit https://review.coreboot.org/19464
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedb2beb5ab96f1632855ac2ca344be68cc892d45
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list