[coreboot-gerrit] Change in coreboot[master]: google/chromeec: Add support for I2C and SPI devices

[Wei-Ning Huang (Code Review)]

Wei-Ning Huang has posted comments on this change. ( https://review.coreboot.org/19464 )

Change subject: google/chromeec: Add support for I2C and SPI devices
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19464/1/src/ec/google/chromeec/acpi/cros_ec.asl
File src/ec/google/chromeec/acpi/cros_ec.asl:

Line 34: 		Name (_HID, "GOOG0008")
> Hm I didn't see that patch upstreamed yet and I didn't realize this would b
The touchpad controller could have 2 owned slave address. We are using one of them for i2c-hid (0x49) and the other (0x1e) for EC host commands. furquan@, it's not a conflict, it was intended to be recognized as a EC i2c device.


-- 
To view, visit https://review.coreboot.org/19464
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedb2beb5ab96f1632855ac2ca344be68cc892d45
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Wei-Ning Huang <wnhuang at google.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes