[coreboot-gerrit] Change in coreboot[master]: google/oak: Support cr50 over i2c on rowan

[Daniel Kurtz (Code Review)]

Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/19364 )

Change subject: google/oak: Support cr50 over i2c on rowan
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/19364/2//COMMIT_MSG
Commit Message:

PS2, Line 17: lib_gpios
> "lb_gpios" (It stands for LinuxBIOS, which was the old name for coreboot in
Done


https://review.coreboot.org/#/c/19364/2/src/mainboard/google/oak/Kconfig
File src/mainboard/google/oak/Kconfig:

Line 26: 	select TPM2
> Gru isn't selecting TPM2 so I think we don't want it either. (When Aaron sa
I see, this should be pulled in by:

 OAK_HAS_TPM2 =>
   select MAINBOARD_HAS_I2C_TPM_CR50 =>
     select MAINBOARD_HAS_TPM2

and:

 CHROMEOS => 
   select VBOOT => select TPM2 if MAINBOARD_HAS_TPM2


-- 
To view, visit https://review.coreboot.org/19364
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6cdd0e39e4ac86538f27f322c55c329179ee084
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes