[coreboot-gerrit] Change in coreboot[master]: google/oak: Support cr50 over i2c on rowan

[Daniel Kurtz (Code Review)]

Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/19364 )

Change subject: google/oak: Support cr50 over i2c on rowan
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/19364/2/src/mainboard/google/oak/Kconfig
File src/mainboard/google/oak/Kconfig:

Line 26: 	select TPM2
> I see, this should be pulled in by:
but... it doesn't actually work.  I get build failures in vboot without out this explicit "select TPM2" here:

build/verstage/vboot/secdata_tpm.o: In function `safe_write':
src/vboot/secdata_tpm.c:165: undefined reference to `tlcl_write'
build/verstage/vboot/secdata_tpm.o: In function `write_secdata':
src/vboot/secdata_tpm.c:128: undefined reference to `tlcl_read'
...


-- 
To view, visit https://review.coreboot.org/19364
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6cdd0e39e4ac86538f27f322c55c329179ee084
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes