[coreboot-gerrit] Change in coreboot[master]: google/oak: Support cr50 over i2c on rowan

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/19364 )

Change subject: google/oak: Support cr50 over i2c on rowan
......................................................................


Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/19364/2//COMMIT_MSG
Commit Message:

PS2, Line 17: lib_gpios
"lb_gpios" (It stands for LinuxBIOS, which was the old name for coreboot in days long gone and still sticks around in some stable APIs.)

Alternatively just say "via the coreboot tables", that's the  overall name of the data structure this ends up in.


https://review.coreboot.org/#/c/19364/2/src/mainboard/google/oak/Kconfig
File src/mainboard/google/oak/Kconfig:

Line 26: 	select TPM2
Gru isn't selecting TPM2 so I think we don't want it either. (When Aaron said "it seems all our boards are selecting it" I think he only looked at x86. I don't think it belongs here, because it's a user-controllable decision that can either be activated explicitly in menuconfig or selected by components that depend on it like VBOOT.)


https://review.coreboot.org/#/c/19364/1/src/mainboard/google/oak/bootblock.c
File src/mainboard/google/oak/bootblock.c:

PS1, Line 92: DGE_RISING);
> This is what Vadim used and afaict, it appears to work.
FWIW Gru also configures it as rising edge.


-- 
To view, visit https://review.coreboot.org/19364
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6cdd0e39e4ac86538f27f322c55c329179ee084
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes