[coreboot-gerrit] Change in coreboot[master]: drv/intel/gma/opregion: Fill in default values

[Prabal Saha (Code Review)]

Prabal Saha has posted comments on this change. ( https://review.coreboot.org/19315 )

Change subject: drv/intel/gma/opregion: Fill in default values
......................................................................


Patch Set 8: Code-Review-1

(2 comments)

Needs to take account a possibility of running a GOP driver instead of a vbios in payload.

https://review.coreboot.org/#/c/19315/8/src/drivers/intel/gma/opregion.c
File src/drivers/intel/gma/opregion.c:

Line 91: 	memcpy(opregion->header.vbios_version, vbt->coreblock_biosbuild,
When a UEFI GOP vbt.bin is passed in from CBFS, and the UEFI GOP driver is run by Tianocore, you do not want to set the vbios version at all. This field should be blank and the GOP version set by the Tianocore payload


Line 125: 	opregion->header.pcon = 259;
I have a better solution than hardcoding pcon that I'll submit in a new patch once this gets upstreamed (or if someone shows me how to make a patch on top of this one)


-- 
To view, visit https://review.coreboot.org/19315
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I159e5511c909da2a7e82b4bc72df226c88da5710
Gerrit-PatchSet: 8
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Prabal Saha <coolstarorganization at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes