[coreboot-gerrit] Change in coreboot[master]: drv/intel/gma/opregion: Fill in default values

[Prabal Saha (Code Review)]

Prabal Saha has posted comments on this change. ( https://review.coreboot.org/19315 )

Change subject: drv/intel/gma/opregion: Fill in default values
......................................................................


Patch Set 8:

(1 comment)

https://review.coreboot.org/#/c/19315/8/src/drivers/intel/gma/opregion.c
File src/drivers/intel/gma/opregion.c:

Line 119: 	opregion->header.version = IGD_OPREGION_VERSION << 24;
Please give me credit for this commit since I was the one who discovered originally that the opregion version needed to be shifted for the Windows driver to work...


and that pcon value was copied from my skylake laptop here for HDMI audio to work in Windows, and clid was initialized to fix internal displays in Windows


-- 
To view, visit https://review.coreboot.org/19315
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I159e5511c909da2a7e82b4bc72df226c88da5710
Gerrit-PatchSet: 8
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Prabal Saha <coolstarorganization at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes