[coreboot-gerrit] Change in coreboot[master]: drv/intel/gma/opregion: Fill in default values

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/19315 )

Change subject: drv/intel/gma/opregion: Fill in default values
......................................................................


Patch Set 8:

(2 comments)

https://review.coreboot.org/#/c/19315/8/src/drivers/intel/gma/opregion.c
File src/drivers/intel/gma/opregion.c:

Line 91: 	memcpy(opregion->header.vbios_version, vbt->coreblock_biosbuild,
> When a UEFI GOP vbt.bin is passed in from CBFS, and the UEFI GOP driver is 
How do you know if a GOP driver is to be run ?
This code is to be used on all platforms.
Should the GOP version fill in the fields it has to ?


Line 119: 	opregion->header.version = IGD_OPREGION_VERSION << 24;
> Please give me credit for this commit since I was the one who discovered or
Please provide the commit id that i can have a look at your fix.


-- 
To view, visit https://review.coreboot.org/19315
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I159e5511c909da2a7e82b4bc72df226c88da5710
Gerrit-PatchSet: 8
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Prabal Saha <coolstarorganization at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes