[coreboot-gerrit] New patch to review for coreboot: AMD k8 fam10: Fix CAR GLOBALS late in romstage

[Kyösti Mälkki (kyosti.malkki@gmail.com)]

Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15754

-gerrit

commit d9c4fe9fd41dfe11fdf9852421e7f5092d5314df
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Wed Jul 20 03:23:06 2016 +0300

    AMD k8 fam10: Fix CAR GLOBALS late in romstage
    
    Zero-filling memory below 1 MiB resets car_migrated variable so
    any CAR GLOBALs are not addressed correctly for the remaining
    time in romstage. Also there is no actual need to do this as
    ramstage loader handles BSS.
    
    This fixes regression with commit 70cd54310 that broke fam10 boards
    with romstage spinlocks enabled.
    
    Change-Id: I7418821997a980ae5b818bd57e8a1b6507a543af
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/cpu/amd/car/post_cache_as_ram.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/cpu/amd/car/post_cache_as_ram.c b/src/cpu/amd/car/post_cache_as_ram.c
index 9cf3c6e..ad5a5c7 100644
--- a/src/cpu/amd/car/post_cache_as_ram.c
+++ b/src/cpu/amd/car/post_cache_as_ram.c
@@ -89,9 +89,6 @@ static void prepare_ramstage_region(int s3resume)
 		if (resume_backup_memory)
 			memcpy_(resume_backup_memory, (void *) CONFIG_RAMBASE,
 				HIGH_MEMORY_SAVE - backup_top);
-		memset_((void*) CONFIG_RAMBASE, 0, HIGH_MEMORY_SAVE - backup_top);
-	} else {
-		memset_((void*)0, 0, CONFIG_RAMTOP - backup_top);
 	}
 
 	print_car_debug(" Done\n");