[coreboot-gerrit] New patch to review for coreboot: intel/fsp1_1: Fix enumeration timestamp and post code

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Fri Jan 15 16:44:39 CET 2016


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12987

-gerrit

commit 925d55c900aa19ee8e88c98b1a8cd2c06bd7fb58
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Thu Dec 17 11:13:01 2015 -0800

    intel/fsp1_1: Fix enumeration timestamp and post code
    
    The timestamps and post codes for the beginning of the FspNotify calls
    are out of order.  Reverse these entries to fix this error.
    
    BRANCH=none
    BUG=None
    TEST=Build and run on kunimitsu
    
    Change-Id: Ibfa1ba4b07e31bf3823469ac2dc7deaa8c67deab
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 3cd63c56c59337f0ff58fd11a78d08352cf6a04a
    Original-Change-Id: I4627860d3ebf446523a5662dbbc8e59153441945
    Original-Signed-off-by: Lee Leahy <Leroy.P.Leahy at intel.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/318903
    Original-Commit-Ready: Leroy P Leahy <leroy.p.leahy at intel.com>
    Original-Tested-by: Leroy P Leahy <leroy.p.leahy at intel.com>
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
 src/drivers/intel/fsp1_1/fsp_util.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/drivers/intel/fsp1_1/fsp_util.c b/src/drivers/intel/fsp1_1/fsp_util.c
index 14ad8c6..1aa3aec 100644
--- a/src/drivers/intel/fsp1_1/fsp_util.c
+++ b/src/drivers/intel/fsp1_1/fsp_util.c
@@ -162,11 +162,11 @@ void fsp_notify(u32 phase)
 	notify_phase_params.Phase = phase;
 
 	if (phase == EnumInitPhaseReadyToBoot) {
-		timestamp_add_now(TS_FSP_BEFORE_ENUMERATE);
-		post_code(POST_FSP_NOTIFY_BEFORE_ENUMERATE);
-	} else {
 		timestamp_add_now(TS_FSP_BEFORE_FINALIZE);
 		post_code(POST_FSP_NOTIFY_BEFORE_FINALIZE);
+	} else {
+		timestamp_add_now(TS_FSP_BEFORE_ENUMERATE);
+		post_code(POST_FSP_NOTIFY_BEFORE_ENUMERATE);
 	}
 
 	status = notify_phase_proc(&notify_phase_params);



More information about the coreboot-gerrit mailing list