[coreboot-gerrit] New patch to review for coreboot: intel/kunimitsu: Set BOOT_BEEP gpio to a default lo

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Fri Jan 15 16:44:42 CET 2016


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12988

-gerrit

commit 8559a4cd7de8668d08ee94149a6a546b57079371
Author: Rohit Ainapure <rohit.m.ainapure at intel.com>
Date:   Thu Dec 17 13:52:53 2015 -0800

    intel/kunimitsu: Set BOOT_BEEP gpio to a default lo
    
    The BOOT_BEEP gpio is used to activate the buffer which
    isolates the I2S signals from PCH while doing a beep from depthcharge.
    It needs to be lo to deactivate the buffer for audio playback from OS.
    
    BUG=chrome-os-partner:47124
    BRANCH=None
    TEST=boot depthcharge & test beep with devbeep.
    Boot OS and test audio playback.
    
    Change-Id: I047513f6cbe9590820dfe3c369161a157864be97
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: d0e04d6792a4511630b8111d0f4a64226042f3e6
    Original-Change-Id: I0fa8f425ac413798740343823d026c6300c8eef1
    Original-Signed-off-by: Rohit Ainapure <rohit.m.ainapure at intel.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/319220
    Original-Commit-Ready: Rohit M Ainapure <rohit.m.ainapure at intel.com>
    Original-Tested-by: Michael Rang <michael.rang at intel.com>
    Original-Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
---
 src/mainboard/intel/kunimitsu/gpio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mainboard/intel/kunimitsu/gpio.h b/src/mainboard/intel/kunimitsu/gpio.h
index 58b1948..911dc22 100755
--- a/src/mainboard/intel/kunimitsu/gpio.h
+++ b/src/mainboard/intel/kunimitsu/gpio.h
@@ -204,7 +204,7 @@ static const struct pad_config gpio_table[] = {
 /* EMMC_DATA7 */	PAD_CFG_NF(GPP_F20, NONE, DEEP, NF1),
 /* EMMC_RCLK */		PAD_CFG_NF(GPP_F21, NONE, DEEP, NF1),
 /* EMMC_CLK */		PAD_CFG_NF(GPP_F22, NONE, DEEP, NF1),
-/* BOOT_BEEP */		PAD_CFG_GPO(GPP_F23, 1, DEEP),
+/* BOOT_BEEP */		PAD_CFG_GPO(GPP_F23, 0, DEEP),
 /* SD_CMD */		PAD_CFG_NF(GPP_G0, NONE, DEEP, NF1),
 /* SD_DATA0 */		PAD_CFG_NF(GPP_G1, NONE, DEEP, NF1),
 /* SD_DATA1 */		PAD_CFG_NF(GPP_G2, NONE, DEEP, NF1),



More information about the coreboot-gerrit mailing list