[coreboot-gerrit] New patch to review for coreboot: intel/skylake: Remove unused devicetree configuration variables

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Fri Jan 15 16:44:36 CET 2016


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12986

-gerrit

commit 11dbb62ccaf12fe435b7a7aa38d1e120984faa41
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Wed Dec 16 16:34:19 2015 -0800

    intel/skylake: Remove unused devicetree configuration variables
    
    The GPU panel configuration variables are unused on skylake
    and are no longer needed in chip.h.
    
    BUG=chrome-os-partner:40635
    BRANCH=none
    TEST=emerge-chell coreboot
    
    Change-Id: Ie6bfb676b5a32b4d4d39dda91b90fc7e973d38e0
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: f261d7ca9ec93aae1362975efde11ac9657b7ca6
    Original-Change-Id: If64594455754e4dea1f53511861b74ddd880c5b5
    Original-Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/318923
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
 src/soc/intel/skylake/chip.h | 23 -----------------------
 1 file changed, 23 deletions(-)

diff --git a/src/soc/intel/skylake/chip.h b/src/soc/intel/skylake/chip.h
index 7e401eb..afb9967 100644
--- a/src/soc/intel/skylake/chip.h
+++ b/src/soc/intel/skylake/chip.h
@@ -58,29 +58,6 @@ struct soc_intel_skylake_config {
 	uint32_t gen3_dec;
 	uint32_t gen4_dec;
 
-	/*
-	 * Digital Port Hotplug Enable:
-	 *  0x04 = Enabled, 2ms short pulse
-	 *  0x05 = Enabled, 4.5ms short pulse
-	 *  0x06 = Enabled, 6ms short pulse
-	 *  0x07 = Enabled, 100ms short pulse
-	 */
-	u8 gpu_dp_b_hotplug;
-	u8 gpu_dp_c_hotplug;
-	u8 gpu_dp_d_hotplug;
-
-	/* Panel power sequence timings */
-	u8 gpu_panel_port_select;
-	u8 gpu_panel_power_cycle_delay;
-	u16 gpu_panel_power_up_delay;
-	u16 gpu_panel_power_down_delay;
-	u16 gpu_panel_power_backlight_on_delay;
-	u16 gpu_panel_power_backlight_off_delay;
-
-	/* Panel backlight settings */
-	u32 gpu_cpu_backlight;
-	u32 gpu_pch_backlight;
-
 	/* Enable S0iX support */
 	int s0ix_enable;
 



More information about the coreboot-gerrit mailing list