[coreboot-gerrit] New patch to review for coreboot: program.ld: make sure that zeroptr isn't assigned to debug sections

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Wed Apr 13 21:02:36 CEST 2016


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14344

-gerrit

commit b2403e688228e43dd9a7e6682786809997d32448
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Wed Apr 13 20:55:34 2016 +0200

    program.ld: make sure that zeroptr isn't assigned to debug sections
    
    Some ld versions seem to merge the .zeroptr section (NOLOAD, address 0)
    with some debug sections (NOLOAD, address 0) which makes the build
    explode when the debug sections are then stripped (including the zeroptr
    symbol).
    
    Just define zeroptr to be 0, no sections needed, to avoid this
    "optimization".
    Checked the objdump -dS of code using it that the accesses look sane.
    
    Change-Id: Ia7cb3e5eae87076caf479d5ae9155a02f74b5663
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
---
 src/lib/program.ld | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/lib/program.ld b/src/lib/program.ld
index 99afe5d..6ffa82a 100644
--- a/src/lib/program.ld
+++ b/src/lib/program.ld
@@ -140,9 +140,7 @@ _eprogram = .;
 
 /* Discard the sections we don't need/want */
 
-.zeroptr 0 (NOLOAD) : {
-	zeroptr = .;
-}
+zeroptr = 0;
 
 /DISCARD/ : {
 	*(.comment)



More information about the coreboot-gerrit mailing list