[coreboot-gerrit] New patch to review for coreboot: superio/smsc/mec1308: Fix AddressMax value for SMBX mailbox

[Martin Roth (martinroth@google.com)]

Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14343

-gerrit

commit 8f0fcf0df9bbaccac385cdbd77d122d4d7427d93
Author: Martin Roth <martinroth at google.com>
Date:   Wed Apr 13 12:20:52 2016 -0600

    superio/smsc/mec1308: Fix AddressMax value for SMBX mailbox
    
    The way this was implemented before was causing ACPI failures.  There
    was also a basic misunderstanding of what the AddressMax field was used
    for.  In this case, because it's a fixed address, it should be the same
    as the AddressMin field.
    
    Getting rid of the addition in the field solves the ACPI output problem.
    
    Change-Id: Idec2bf0ed27ae694e98f141087cdf22401937178
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 src/superio/smsc/mec1308/acpi/superio.asl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/superio/smsc/mec1308/acpi/superio.asl b/src/superio/smsc/mec1308/acpi/superio.asl
index 6794448..cc174f9 100644
--- a/src/superio/smsc/mec1308/acpi/superio.asl
+++ b/src/superio/smsc/mec1308/acpi/superio.asl
@@ -246,12 +246,12 @@ Device (SIO) {
 
 		Name (_CRS, ResourceTemplate()
 		{
-			IO (Decode16, SIO_SMBX_IO0, SIO_SMBX_IO0 + 0x34, 0x01, 0x34)
+			IO (Decode16, SIO_SMBX_IO0, SIO_SMBX_IO0, 0x01, 0x34)
 		})
 
 		Name (_PRS, ResourceTemplate()
 		{
-			IO (Decode16, SIO_SMBX_IO0, SIO_SMBX_IO0 + 0x34, 0x01, 0x34)
+			IO (Decode16, SIO_SMBX_IO0, SIO_SMBX_IO0, 0x01, 0x34)
 		})
 	}
 #endif