[coreboot-gerrit] New patch to review for coreboot: SeaBIOS: Change clean to just 'rm -rf seabios/out'

Martin Roth (gaumless@gmail.com) gerrit at coreboot.org
Thu Jun 25 03:43:33 CEST 2015

Martin Roth (gaumless at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10655


commit 0b47087b67d00c725cd210b59ae0df83ce05ed53
Author: Martin Roth <gaumless at gmail.com>
Date:   Wed Jun 24 19:43:17 2015 -0600

    SeaBIOS: Change clean to just 'rm -rf seabios/out'
    When running 'make clean' if the seabios directory is present, we get
    warnings about not having IASL installed or that the C compiler can't
    be executed.  It fails to actually run the clean because we're not
    correctly passing in the toolchain.
    Just do what the SeaBIOS clean does directly and delete the 'out'
    directory without actually calling the SeaBIOS clean.
    Here were the previous warnings:
    % make clean
    Unable to execute the C compiler ().
    Please install a working compiler and retry.
    Makefile:104: *** "Please upgrade the build environment".  Stop.
    % make clean
    The SeaBIOS project requires the 'iasl' package be installed.
    Many Linux distributions have this package.
    Try: sudo yum install iasl
    Or: sudo apt-get install iasl
    Please install iasl and retry.
    Makefile:106: *** "Please upgrade the build environment".  Stop.
    Change-Id: Ice41376bc242f1f622d849e7628f8a9b6ef47404
    Signed-off-by: Martin Roth <gaumless at gmail.com>
 payloads/external/SeaBIOS/Makefile.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/payloads/external/SeaBIOS/Makefile.inc b/payloads/external/SeaBIOS/Makefile.inc
index 087b723..7fb63d4 100644
--- a/payloads/external/SeaBIOS/Makefile.inc
+++ b/payloads/external/SeaBIOS/Makefile.inc
@@ -53,7 +53,7 @@ build: config
 	$(MAKE) -C seabios OUT=out/
-	test -d seabios && $(MAKE) -C seabios clean OUT=out/ || exit 0
+	test -d seabios/out && rm -rf seabios/out || exit 0
 	rm -rf seabios

More information about the coreboot-gerrit mailing list