[SeaBIOS] [PATCH 1/4] Fix return type of le64_to_cpu() and be64_to_cpu()

[Kevin O'Connor]

On Sat, Feb 23, 2013 at 04:28:06PM +0000, David Woodhouse wrote:
> On Sat, 2013-02-23 at 10:00 -0500, Kevin O'Connor wrote:
> > Patch 2 and 3 look okay to me - if there are no further comments I'll
> > push them.
> 
> I think we're fairly happy with them. Laszlo put together the OVMF side
> (creating ACPI 2.0 tables instead of 1.0 and filling in the RESET_REG)
> and I've tested that it's doing the right thing. We should probably do
> something similar on the SeaBIOS side when it's creating its own tables,
> and feed same to acpi_set_reset_reg().

IMO, we need to move the ACPI table creation (and PIR/MPTABLE/SMBIOS)
to QEMU and just have QEMU pass the tables to SeaBIOS for it to copy
into memory like it does on CSM, coreboot, and Xen.

> > I'm not sure about patch 4.  I do think we want to try the "standard"
> > ways before poking at unstandard ports.
> 
> Yeah, maybe. Perhaps we could enable that only if PCI devices 8086/7113
> or 8086/2918 were found in pci_probe_devices() ? 

If you want to call acpi_set_reset_reg() from pciinit.c (like the way
pmtimer_setup() is called) or something similar, that's fine with me.

-Kevin