[SeaBIOS] [PATCH 1/4] Fix return type of le64_to_cpu() and be64_to_cpu()

[David Woodhouse]

On Sat, 2013-02-23 at 10:00 -0500, Kevin O'Connor wrote:
> Patch 2 and 3 look okay to me - if there are no further comments I'll
> push them.

I think we're fairly happy with them. Laszlo put together the OVMF side
(creating ACPI 2.0 tables instead of 1.0 and filling in the RESET_REG)
and I've tested that it's doing the right thing. We should probably do
something similar on the SeaBIOS side when it's creating its own tables,
and feed same to acpi_set_reset_reg().

> I'm not sure about patch 4.  I do think we want to try the "standard"
> ways before poking at unstandard ports.

Yeah, maybe. Perhaps we could enable that only if PCI devices 8086/7113
or 8086/2918 were found in pci_probe_devices() ? 

Then again, if we *do* find those devices then our ACPI tables should
have given us 0xcf9 as a RESET_REG. So perhaps patch #4 is superfluous.

-- 
dwmw2

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 6171 bytes
Desc: not available
URL: <http://www.seabios.org/pipermail/seabios/attachments/20130223/4e21b360/attachment.bin>