[SeaBIOS] [PATCH 8/8] Convert some QEMU cmos config variables to the romfile interface.

Kevin O'Connor kevin at koconnor.net
Thu Feb 14 00:54:42 CET 2013


On Wed, Feb 13, 2013 at 12:33:20PM +0100, Paolo Bonzini wrote:
> Il 13/02/2013 02:57, Kevin O'Connor ha scritto:
> >> > The right thing to would be to use the FADT century field.  In fact we
> >> > should also set the century field to 0x32 under QEMU.
> > I'm not much of a fan of storing content in the CMOS.
> 
> This is time data, where does it belong if not in the CMOS?

It still has the challenge of knowing where in the CMOS to put it, and
where in the CMOS to update the checksum if it needs to change.

That aside, though, I'm not really happy about patch 8 anyway -
additional complexity and indirection for no real gain, so I'll
withdraw patch 8 for consideration.  The first 7 patches I think are
still a simplification.

Thanks.
-Kevin



More information about the SeaBIOS mailing list