[SeaBIOS] [PATCH] Start device_hardware_setup in mainint even with CONFIG_THREAD_OPTIONROMS.

Kevin O'Connor kevin at koconnor.net
Sun Feb 10 06:55:28 CET 2013


There's no real gain to starting the device_hardware_setup in the
middle of the platform setup.  Always start it just prior to the VGA
rom.

Signed-off-by: Kevin O'Connor <kevin at koconnor.net>
---
 src/post.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/src/post.c b/src/post.c
index 2d5dd4f..1dfbb21 100644
--- a/src/post.c
+++ b/src/post.c
@@ -163,19 +163,13 @@ platform_hardware_setup(void)
     pci_setup();
     smm_setup();
 
-    // Initialize mtrr
+    // Initialize mtrr and smp
     mtrr_setup();
+    smp_setup();
 
     // Setup Xen hypercalls
     xen_hypercall_setup();
 
-    // Start hardware initialization (if optionrom threading)
-    if (CONFIG_THREAD_OPTIONROMS)
-        device_hardware_setup();
-
-    // Find and initialize other cpus
-    smp_setup();
-
     // Setup external BIOS interface tables
     if (CONFIG_COREBOOT)
         coreboot_biostable_setup();
@@ -225,6 +219,10 @@ maininit(void)
     // Setup platform devices.
     platform_hardware_setup();
 
+    // Start hardware initialization (if optionrom threading)
+    if (CONFIG_THREAD_OPTIONROMS)
+        device_hardware_setup();
+
     // Run vga option rom
     vgarom_setup();
 
-- 
1.7.11.7




More information about the SeaBIOS mailing list