[SeaBIOS] [PATCH 13/20] acpi: move \_SB.PCI0._CRS to separate file

Kevin O'Connor kevin at koconnor.net
Wed Nov 28 01:17:41 CET 2012


On Tue, Nov 27, 2012 at 10:21:04AM +0100, Gerd Hoffmann wrote:
> --- /dev/null
> +++ b/src/acpi-dsdt-pci-crs.dsl
> @@ -0,0 +1,104 @@
> +            Name (CRES, ResourceTemplate ()
> +            {
> +                WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode,
[...]
> --- a/src/acpi-dsdt.dsl
> +++ b/src/acpi-dsdt.dsl
> @@ -106,110 +106,8 @@ DefinitionBlock (
[...]
> +#include "acpi-dsdt-pci-crs.dsl"
[...]
>          }
>      }

I think this makes sense.  However, I think it would be nicer to put
an explicit scope at the beginning of the file (ie, Scope (\SB.PCI0) )
instead of nesting the include.

-Kevin



More information about the SeaBIOS mailing list