[SeaBIOS] [PATCH 13/20] acpi: move \_SB.PCI0._CRS to separate file

Gerd Hoffmann kraxel at redhat.com
Wed Nov 28 07:55:07 CET 2012


On 11/28/12 01:17, Kevin O'Connor wrote:
> On Tue, Nov 27, 2012 at 10:21:04AM +0100, Gerd Hoffmann wrote:
>> --- /dev/null
>> +++ b/src/acpi-dsdt-pci-crs.dsl
>> @@ -0,0 +1,104 @@
>> +            Name (CRES, ResourceTemplate ()
>> +            {
>> +                WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode,
> [...]
>> --- a/src/acpi-dsdt.dsl
>> +++ b/src/acpi-dsdt.dsl
>> @@ -106,110 +106,8 @@ DefinitionBlock (
> [...]
>> +#include "acpi-dsdt-pci-crs.dsl"
> [...]
>>          }
>>      }
> 
> I think this makes sense.  However, I think it would be nicer to put
> an explicit scope at the beginning of the file (ie, Scope (\SB.PCI0) )
> instead of nesting the include.

I'll try.  IIRC I've had problems with iasl complaining about duplicate
devices in a simliar case, so I'm not sure this works out.

cheers,
  Gerd




More information about the SeaBIOS mailing list