[OpenBIOS] [PATCH 2/2] implement convert_to_ints()

Segher Boessenkool segher at kernel.crashing.org
Sun Sep 25 09:00:17 CEST 2016


On Sun, Sep 25, 2016 at 12:56:10AM -0400, Programmingkid wrote:
> 
> On Sep 25, 2016, at 12:50 AM, Segher Boessenkool wrote:
> 
> > On Sat, Sep 24, 2016 at 12:56:40PM -0400, Programmingkid wrote:
> >> +/* Converts the QEMU,VGA node's resolutions property to int's*/
> > 
> > And store them, where?
> In the resolutions property.

In the resolutions property _where_?

This should be part of the comment here, of course.

> >> +void convert_to_ints(void)
> > 
> > Since almost everything here just calls Forth words, can't you write
> > it in actual Forth instead?  ">number" is your friend.
> 
> ...but Forth is not. C is a lot easier to me to use than Forth.

Then learn to use it better!  :-)


Segher



More information about the OpenBIOS mailing list