[OpenBIOS] [PATCH 2/2] implement convert_to_ints()

G 3 programmingkidx at gmail.com
Sun Sep 25 16:45:39 CEST 2016


On Sep 25, 2016, at 3:00 AM, Segher Boessenkool wrote:

> On Sun, Sep 25, 2016 at 12:56:10AM -0400, Programmingkid wrote:
>>
>> On Sep 25, 2016, at 12:50 AM, Segher Boessenkool wrote:
>>
>>> On Sat, Sep 24, 2016 at 12:56:40PM -0400, Programmingkid wrote:
>>>> +/* Converts the QEMU,VGA node's resolutions property to int's*/
>>>
>>> And store them, where?
>> In the resolutions property.
>
> In the resolutions property _where_?

In the /pci/QEMU,VGA node.

>
> This should be part of the comment here, of course.
>
>>>> +void convert_to_ints(void)
>>>
>>> Since almost everything here just calls Forth words, can't you write
>>> it in actual Forth instead?  ">number" is your friend.
>>
>> ...but Forth is not. C is a lot easier to me to use than Forth.
>
> Then learn to use it better!  :-)

The convert_to_ints() function is just too complex for me to write it  
in Forth.
C is so much nicer.




More information about the OpenBIOS mailing list