[OpenBIOS] [PATCH 3/5] adb: Don't assume that pointers fit in 32 bits

Andreas Färber andreas.faerber at web.de
Sat Oct 30 14:45:48 CEST 2010

Am 30.10.2010 um 13:56 schrieb Alexander Graf:

> On 30.10.2010, at 04:51, Andreas Färber wrote:
>> Hello Alex,
>> Are you able to ack this patch? Or are there any reasons why the  
>> state must be uint32_t?
> Uh, looks good to me. It seems to only be a temporary storage for a  
> pointer anyways, so I have no idea why it'd be kept as u32.
>> The ppc64 mac99 machine still uses ADB and apparently OpenBIOS  
>> doesn't support USB keyboards yet.
> Yeah, that piece is very broken though. Linux doesn't even allow you  
> to compile in support for the ADB controller we have there on ppc64  
> Linux :(.
> Acked-by: Alexander Graf <agraf at suse.de>

Thanks, applied in r924.

Concerning ADB on ppc64, I think this is related to the OHCI warning  
on the serial console and complete lack of USB controller support in  
drivers/pci_database.c except for usb_iface definitions. Any help  
fixing this would be appreciated. I guess we would need the equivalent  
of sys_devices mapping the PCI IDs to OF property strings and values?


More information about the OpenBIOS mailing list