[OpenBIOS] [PATCH 3/5] adb: Don't assume that pointers fit in 32 bits

Alexander Graf agraf at suse.de
Sat Oct 30 13:56:59 CEST 2010

Hey Andreas,

On 30.10.2010, at 04:51, Andreas Färber wrote:

> Hello Alex,
> Are you able to ack this patch? Or are there any reasons why the state must be uint32_t?

Uh, looks good to me. It seems to only be a temporary storage for a pointer anyways, so I have no idea why it'd be kept as u32.

> The ppc64 mac99 machine still uses ADB and apparently OpenBIOS doesn't support USB keyboards yet.

Yeah, that piece is very broken though. Linux doesn't even allow you to compile in support for the ADB controller we have there on ppc64 Linux :(.

Acked-by: Alexander Graf <agraf at suse.de>


More information about the OpenBIOS mailing list