[OpenBIOS] [commit] r921 - trunk/openbios-devel/libopenbios
repository service
svn at openbios.org
Mon Oct 25 21:26:40 CEST 2010
Author: afaerber
Date: Mon Oct 25 21:26:40 2010
New Revision: 921
URL: http://tracker.coreboot.org/trac/openbios/changeset/921
Log:
CIF: Fix trace output for claim and release
A misplaced digit 8 made it look as if some signedness issue was present
somewhere between libopenbios/client.c:of_client_interface() and
arch/ppc/qemu/methods.c:ciface_claim(). This is not the case;
despite unsigned long -> ucell -> cell -> ucell conversions,
PUSH'ing 0x81234567 and POP'ing works as expected.
Fix the format string to avoid such confusion.
Add zero-padding while at it.
Signed-off-by: Andreas Färber <andreas.faerber at web.de>
Modified:
trunk/openbios-devel/libopenbios/client.c
Modified: trunk/openbios-devel/libopenbios/client.c
==============================================================================
--- trunk/openbios-devel/libopenbios/client.c Sun Oct 24 23:34:21 2010 (r920)
+++ trunk/openbios-devel/libopenbios/client.c Mon Oct 25 21:26:40 2010 (r921)
@@ -132,10 +132,10 @@
pb->args[0], pb->args[1], pb->args[2]);
#endif
} else if (strcmp(pb->service, "claim") == 0) {
- printk("claim(0x8%lx, %ld, %ld) = ",
+ printk("claim(0x%08lx, %ld, %ld) = ",
pb->args[0], pb->args[1], pb->args[2]);
} else if (strcmp(pb->service, "release") == 0) {
- printk("release(0x8%lx, %ld)\n",
+ printk("release(0x%08lx, %ld)\n",
pb->args[0], pb->args[1]);
} else if (strcmp(pb->service, "boot") == 0) {
printk("boot \"%s\"\n", (char*)pb->args[0]);
More information about the OpenBIOS
mailing list