[OpenBIOS] [commit] r915 - trunk/openbios-devel/arch/sparc32
Andreas Färber
andreas.faerber at web.de
Tue Oct 19 18:08:49 CEST 2010
Am 19.10.2010 um 16:22 schrieb Mark Cave-Ayland:
> Artyom Tarasenko wrote:
>
>>> What do you think of the following patch? It should solve your
>>> problem with
>>> the last 0 argument, preserves stack content between calls and is
>>> probably
>>> easier to read too.
>> Yes, I like this version more.
>
> [...] Does anyone else have a preference one way or the other on
> this patch?
I concur with Artyom. The client interface does a similar stack check/
correction iirc.
Often simple is better, and your new patch indeed looks much more
readable to me.
Haven't tested either one yet; which version of Solaris did you use?
Andreas
More information about the OpenBIOS
mailing list