[OpenBIOS] [PATCH v5 3/5] Pretty-print reg property

[Andreas Färber]

Am 12.11.2010 um 23:40 schrieb Segher Boessenkool:

>>>> +    " #size-cells" rot get-package-property if 1 exit then
>>>> +    \ we don't have to support more than 4
>>>> +    decode-int nip nip 0 max
>>>
>>> It's not a signed number, so it should be umax, not max.
>>> But "0 umax" is a noop.  Just remove it, use the value
>>> as-is.
>>
>> Your loop uses them as signed numbers though...
>
> "My loop"?

Your optimized version of my .p-reg word - iiuc - uses a loop counter  
going from + my-#acells to - my-#scells, thereby treating the property  
values as signed numbers on sparc32, ppc, ppc64 (where cell size == 4).
Practically speaking it doesn't matter though since I haven't seen  
such large #size-cells anywhere yet. :)

Andreas