[OpenBIOS] [PATCH v5 3/5] Pretty-print reg property
Segher Boessenkool
segher at kernel.crashing.org
Fri Nov 12 23:40:30 CET 2010
>>> + " #size-cells" rot get-package-property if 1 exit then
>>> + \ we don't have to support more than 4
>>> + decode-int nip nip 0 max
>>
>> It's not a signed number, so it should be umax, not max.
>> But "0 umax" is a noop. Just remove it, use the value
>> as-is.
>
> Your loop uses them as signed numbers though...
"My loop"?
> Your quote also shows a stray comment that I'll remove.
Yeah, it's somewhat out of place here.
Thanks,
Segher
More information about the OpenBIOS
mailing list