[flashrom] [PATCH] CID1130004: Nesting level does not match indentation

Stefan Tauner stefan.tauner at alumni.tuwien.ac.at
Sat Apr 26 20:47:40 CEST 2014


On Tue, 19 Nov 2013 20:35:57 +0100
Stefan Reinauer <stefan.reinauer at coreboot.org> wrote:

> CID1130004: Nesting level does not match indentation
> 
> Code that is meant to be executed conditionally may be executed unconditionally
> In print_supported_boards_helper: The indentation of this code suggests it is
> nested when it is not.
> 
> Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
> 
> Index: print.c
> ===================================================================
> --- print.c	(revision 1763)
> +++ print.c	(working copy)
> @@ -436,13 +436,14 @@
>  		msg_ginfo("%s", b->name);
>  		for (i = 0; i < maxboardlen - strlen(b->name); i++)
>  			msg_ginfo(" ");
> -			if (b->working == OK)
> -				msg_ginfo("OK      ");
> -			else if (b->working == NT)
> -				msg_ginfo("NT      ");
> -			else
> -				msg_ginfo("BAD     ");
>  
> +		if (b->working == OK)
> +			msg_ginfo("OK      ");
> +		else if (b->working == NT)
> +			msg_ginfo("NT      ");
> +		else
> +			msg_ginfo("BAD     ");
> +
>  		for (e = board_matches; e->vendor_name != NULL; e++) {
>  			if (strcmp(e->vendor_name, b->vendor)
>  			    || strcmp(e->board_name, b->name))

Acked-by: Stefan Tauner <stefan.tauner at alumni.tuwien.ac.at>
and committed in r1770, thanks!

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner




More information about the flashrom mailing list