[flashrom] [PATCH] CID1130012: Double free

Stefan Tauner stefan.tauner at alumni.tuwien.ac.at
Sat Apr 26 20:47:59 CEST 2014


On Tue, 19 Nov 2013 20:35:57 +0100
Stefan Reinauer <stefan.reinauer at coreboot.org> wrote:

> CID1130012: Double free
> 
> Depending on the implementation of the deallocator function, the memory may by
> placed on the free list more than once.
> In pony_spi_init: Memory is deallocated more than once
> 
> Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
> 
> Index: pony_spi.c
> ===================================================================
> --- pony_spi.c	(revision 1763)
> +++ pony_spi.c	(working copy)
> @@ -140,6 +140,7 @@
>  	} else if (arg && !strlen(arg)) {
>  		msg_perr("Error: Missing argument for programmer type.\n");
>  		free(arg);
> +		return 1;
>  	} else if (arg){
>  		msg_perr("Error: Invalid programmer type specified.\n");
>  		free(arg);

Acked-by: Stefan Tauner <stefan.tauner at alumni.tuwien.ac.at>
and committed in r1772, thanks!

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner




More information about the flashrom mailing list