[flashrom] Flashrom patch submission

Stefan Tauner stefan.tauner at student.tuwien.ac.at
Mon Jun 17 19:12:22 CEST 2013


On Mon, 17 Jun 2013 16:02:09 +0000
Greg Schardt <gschardt at ddn.com> wrote:

> I have modified flashrom_0.9.6.1 so that the layout file is used for reads, writes, and verifies, as well as ensuring that no other regions are touched during any operation, so that locked regions do not cause transaction errors. I would like to submit a patch, but do not know the procedure, or the preferred diff options for producing the patch. I do not plan to do any other development, so would prefer not having to learn a large procedure.

Hello Greg,

thanks for trying to contribute back! Are you aware of my layout
patches that do approximately the same thing? What did you do
differently?

In general the best way to do such things is to use a version control
system from beginning and do smaller commits on the go.
If you started with the sources extracted from the 0.9.6.1 release,
then the easiest way is probably to extract that a second time to
another directory and create a patch file that contains all differences
between the two trees.
There are many howtos on how to do this, e.g.
http://jungels.net/articles/diff-patch-ten-minutes.html

Then you need to legally sign-off the resulting patch (i.e. add a single
line to the mail when sending the patch), see
http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure
(and http://flashrom.org/Development_Guidelines)

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner




More information about the flashrom mailing list