[flashrom] [PATCH] do something useful with the dediprog LEDs

[Stefan Reinauer]

On Mon, Jan 24, 2011 at 2:14 AM, Mathias Krause
<mathias.krause at secunet.com> wrote:
> On 21.01.2011 20:09, Stefan Reinauer wrote:
>> This patch makes use of the dediprog LEDs.
>
> Nice!
>
>> It would be nice to have some "more global" infrastructure for device
>> dependent status reporting. Right now some scenarios can not be
>> reported as an error, though the user would think of them as one. For
>> example, if the chip is IDed successfully but not supported by
>> flashrom, thus it can not be flashed. At best, the dediprog driver
>> sees a successful RDID command, but has no knowledge about the failure
>> to read/write the chip. Therefore it can not report it.
>>
>> However, the attached patch improves my work flow here quite a bit, so
>> I thought it should be shared.
>
> Thanks for the patch. Albeit it would be good to have a "noleds" option
> to disable the functionality because we don't know if it breaks older
> firmware versions.

All changes added, except this one. Instead the updated version
explicitly support older firmware versions.

-- 
Stefan Reinauer
Google Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dediprog_leds.diff
Type: text/x-patch
Size: 7170 bytes
Desc: not available
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20110127/d7a13ff4/attachment.diff>