[flashrom] [PATCH] do something useful with the dediprog LEDs

Stefan Reinauer reinauer at google.com
Mon Jan 24 20:19:26 CET 2011

* Mathias Krause <mathias.krause at secunet.com> [110124 11:14]:
> On 21.01.2011 20:09, Stefan Reinauer wrote:
> > This patch makes use of the dediprog LEDs.
> Nice!
> > It would be nice to have some "more global" infrastructure for device
> > dependent status reporting. Right now some scenarios can not be
> > reported as an error, though the user would think of them as one. For
> > example, if the chip is IDed successfully but not supported by
> > flashrom, thus it can not be flashed. At best, the dediprog driver
> > sees a successful RDID command, but has no knowledge about the failure
> > to read/write the chip. Therefore it can not report it.
> > 
> > However, the attached patch improves my work flow here quite a bit, so
> > I thought it should be shared.
> Thanks for the patch. Albeit it would be good to have a "noleds" option
> to disable the functionality because we don't know if it breaks older
> firmware versions.

Ok, I'll hold it off until we get a test report from an older firmware
version. I'd like to avoid adding the noleds option if possible, and
make the code contain the knowledge about the capabilities of the
firmware version rather than the user.

Thanks for the review. I fixed your findings.


More information about the flashrom mailing list