[flashrom] [patch] partial write test script

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Fri Oct 29 23:27:04 CEST 2010


On 29.10.2010 22:51, David Hendricks wrote:
> When running the script, it seems that the added "$FLASHROM_PARAM" can get
> expanded incorrectly by the shell thus causing flashrom to barf when
> $FLASHROM_PARAM is empty. I suspect it quietly passes in "".
>
> The attached patch is a simple s/\"$FLASHROM_PARAM\"/${FLASHROM_PARAM}/g.
> This seems to work.
>
> My shell-fu is only moderate, perhaps someone with more expertise can verify
> that this is the -correct- way to do it.
>   

If you reply to this with a Signed-off-by line, this is
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the flashrom mailing list