[flashrom] [PATCH] Pre-release polishing

Uwe Hermann uwe at hermann-uwe.de
Fri Mar 26 01:17:04 CET 2010


On Wed, Mar 17, 2010 at 07:07:50PM +0100, Carl-Daniel Hailfinger wrote:
> > -/* sp_prev_was_write used to detect writes with continouous addresses
> > +/* sp_prev_was_write used to detect writes with continuous addresses
> >   
> 
> Shouldn't that be "contiguous"?

Probably, yes. Fixed.


> > Index: board_enable.c
> > ===================================================================
> > --- board_enable.c	(Revision 947)
> > +++ board_enable.c	(Arbeitskopie)
> >   
> 
> Can you please check these hunks for conflicts with existing unmerged
> board enable patches? I'd rather keep the additional work for merging
> them at a manageable level.

Should no longer be a problem, most stuff was merged.


> It is unclear whether nvidia has the official spelling NVIDIA or nVIDIA
> or nVidia. It may have changed over time.

True, but the current website seems to use NVIDIA quite consistently, so
I'd use that variant.

 
> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Thanks, r985.

 
Uwe.
-- 
http://www.hermann-uwe.de  | http://www.randomprojects.org
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org




More information about the flashrom mailing list