[flashrom] [PATCH] Pre-release polishing
c-d.hailfinger.devel.2006 at gmx.net
Wed Mar 17 19:07:50 CET 2010
On 17.03.2010 18:36, Uwe Hermann wrote:
> Polish the flashrom code comments and outputs a bit.
> - Fix a number of typos (found via ispell).
> - Use correct vendor names (as per their websites) consistently.
> Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>
> Index: serprog.c
> --- serprog.c (Revision 947)
> +++ serprog.c (Arbeitskopie)
> @@ -66,7 +66,7 @@
> /* Bitmap of supported commands */
> static uint8_t sp_cmdmap;
> -/* sp_prev_was_write used to detect writes with continouous addresses
> +/* sp_prev_was_write used to detect writes with continuous addresses
Shouldn't that be "contiguous"?
> and combine them to write-n's */
> Index: board_enable.c
> --- board_enable.c (Revision 947)
> +++ board_enable.c (Arbeitskopie)
Can you please check these hunks for conflicts with existing unmerged
board enable patches? I'd rather keep the additional work for merging
them at a manageable level.
It is unclear whether nvidia has the official spelling NVIDIA or nVIDIA
or nVidia. It may have changed over time.
If you have answers for the serprog and board enable stuff (which may
require leaving out the board enable part for now), this is
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
"I do consider assignment statements and pointer variables to be among
computer science's most valuable treasures."
-- Donald E. Knuth
More information about the flashrom