[flashrom] [PATCH] Simplify get_next_write

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sun Dec 5 23:56:56 CET 2010


Simplify get_next_write in the partial write code.

Suggested by Michael Karcher.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Index: flashrom-partial_write_get_next_write_simplify/flashrom.c
===================================================================
--- flashrom-partial_write_get_next_write_simplify/flashrom.c	(Revision 1245)
+++ flashrom-partial_write_get_next_write_simplify/flashrom.c	(Arbeitskopie)
@@ -928,13 +928,11 @@
 				/* First location where have and want
 				 * do not differ anymore.
 				 */
-				first_len = i * stride - rel_start;
 				break;
 			}
 		}
 	}
-	/* Did the loop terminate without setting first_len? */
-	if (need_write && ! first_len)
+	if (need_write)
 		first_len = min(i * stride - rel_start, len);
 	*first_start += rel_start;
 	return first_len;


-- 
http://www.hailfinger.org/





More information about the flashrom mailing list