[flashrom] consts and copies

[Stefan Reinauer]

On 11/27/09 12:54 AM, Carl-Daniel Hailfinger wrote:
> - Handling chips with varying sizes (based on some config byte) is
> broken by this change.
>   
Which chips are that?

> - Since such a change will break every other unapplied patch out there,
> the only chance this has in getting in is when the patch queue size is
> near zero. Won't happen anytime soon if the current review rate (more
> patches sent than reviewed) is any indication.
>   
Makes sense.

> Plus, we have to convert all of printf(), printf_debug(),
> fprintf(stderr,) to wrapper functions which can be compiled out or be
> adapted to serialice.
that should happen anyways..

> And we need a rewritten main(). Doable, but post
> 0.9.2 material (unless someone sends easy-to-review patches).
>   
I'd refrain from making main() part of this.. All the other stuff is
libpayload material... so main() can be done by whoever uses libpayload
then...

> I don't want to discourage you, but it won't be a walk in the park.
>
>   
Ok, let's delay this until after 0.9.2

Stefan