[coreboot] New Defects reported by Coverity Scan for coreboot

scan-admin at coverity.com scan-admin at coverity.com
Fri Sep 22 16:44:18 CEST 2017


Hi,

Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan.

5 new defect(s) introduced to coreboot found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)


** CID 1381373:  Control flow issues  (MISSING_BREAK)
/src/device/dram/ddr2.c: 197 in spd_decode_tRR_time()


________________________________________________________________________________________________________
*** CID 1381373:  Control flow issues  (MISSING_BREAK)
/src/device/dram/ddr2.c: 197 in spd_decode_tRR_time()
191     	switch (c) {
192     	default:
193     		printk(BIOS_WARNING, "Invalid tRR value 0x%x\n", c);
194     		return CB_ERR;
195     	case 0x80:
196     		*tRR = 15625 << 8;
>>>     CID 1381373:  Control flow issues  (MISSING_BREAK)
>>>     The above case falls through to this one.
197     	case 0x81:
198     		*tRR = 15625 << 6;
199     	case 0x82:
200     		*tRR = 15625 << 7;
201     	case 0x83:
202     		*tRR = 15625 << 9;

** CID 1381372:  Control flow issues  (MISSING_BREAK)
/src/device/dram/ddr2.c: 199 in spd_decode_tRR_time()


________________________________________________________________________________________________________
*** CID 1381372:  Control flow issues  (MISSING_BREAK)
/src/device/dram/ddr2.c: 199 in spd_decode_tRR_time()
193     		printk(BIOS_WARNING, "Invalid tRR value 0x%x\n", c);
194     		return CB_ERR;
195     	case 0x80:
196     		*tRR = 15625 << 8;
197     	case 0x81:
198     		*tRR = 15625 << 6;
>>>     CID 1381372:  Control flow issues  (MISSING_BREAK)
>>>     The above case falls through to this one.
199     	case 0x82:
200     		*tRR = 15625 << 7;
201     	case 0x83:
202     		*tRR = 15625 << 9;
203     	case 0x84:
204     		*tRR = 15625 << 10;

** CID 1381371:  Control flow issues  (MISSING_BREAK)
/src/device/dram/ddr2.c: 203 in spd_decode_tRR_time()


________________________________________________________________________________________________________
*** CID 1381371:  Control flow issues  (MISSING_BREAK)
/src/device/dram/ddr2.c: 203 in spd_decode_tRR_time()
197     	case 0x81:
198     		*tRR = 15625 << 6;
199     	case 0x82:
200     		*tRR = 15625 << 7;
201     	case 0x83:
202     		*tRR = 15625 << 9;
>>>     CID 1381371:  Control flow issues  (MISSING_BREAK)
>>>     The above case falls through to this one.
203     	case 0x84:
204     		*tRR = 15625 << 10;
205     	case 0x85:
206     		*tRR = 15625 << 11;
207     	}
208     	return CB_SUCCESS;

** CID 1381370:  Control flow issues  (MISSING_BREAK)
/src/device/dram/ddr2.c: 205 in spd_decode_tRR_time()


________________________________________________________________________________________________________
*** CID 1381370:  Control flow issues  (MISSING_BREAK)
/src/device/dram/ddr2.c: 205 in spd_decode_tRR_time()
199     	case 0x82:
200     		*tRR = 15625 << 7;
201     	case 0x83:
202     		*tRR = 15625 << 9;
203     	case 0x84:
204     		*tRR = 15625 << 10;
>>>     CID 1381370:  Control flow issues  (MISSING_BREAK)
>>>     The above case falls through to this one.
205     	case 0x85:
206     		*tRR = 15625 << 11;
207     	}
208     	return CB_SUCCESS;
209     }
210     

** CID 1381369:  Control flow issues  (MISSING_BREAK)
/src/device/dram/ddr2.c: 201 in spd_decode_tRR_time()


________________________________________________________________________________________________________
*** CID 1381369:  Control flow issues  (MISSING_BREAK)
/src/device/dram/ddr2.c: 201 in spd_decode_tRR_time()
195     	case 0x80:
196     		*tRR = 15625 << 8;
197     	case 0x81:
198     		*tRR = 15625 << 6;
199     	case 0x82:
200     		*tRR = 15625 << 7;
>>>     CID 1381369:  Control flow issues  (MISSING_BREAK)
>>>     The above case falls through to this one.
201     	case 0x83:
202     		*tRR = 15625 << 9;
203     	case 0x84:
204     		*tRR = 15625 << 10;
205     	case 0x85:
206     		*tRR = 15625 << 11;


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbLuoVetFLSjdonCi1EjfHRqWGQvojmmkYaBE-2BPJiTQvQ-3D-3D_q4bX76XMySz3BXBlWr5fXXJ4cvAsgEXEqC7dBPM7O5YQrTOdvuJ31PG5uq7Aft4-2Bhihw4wCOn6DR5SNl7lwu3AqOBVw21pZnBvyNK-2BOA9Xng2MTN13kNfLJ8PBugmctuje3zbR-2BDcT7DdVvs-2Fgs30ONMXwAHqsXgYxFmc88T3xgOslng06VvWVNJIfsGi4GmIK3NQlKrHRDnQ1grD9W-2BZYuVLKedO6-2FYUULRdxFIo08-3D

To manage Coverity Scan email notifications for "coreboot at coreboot.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4e-2BpBzwOa5gzBZa9dWpDbzfofODnVj1enK2UkK0-2BgCCqfkfgGF5ECMwHI0-2FVznrU953Dvw3Ddjop950pccFQ-2Br0qaXkQSgAjbZsF6g7Yem3Y-3D_q4bX76XMySz3BXBlWr5fXXJ4cvAsgEXEqC7dBPM7O5YQrTOdvuJ31PG5uq7Aft4-2B0ini-2Fm5288njr-2BTFAdtgIuMEpFeRKQmqKleSo7v5i2E3TpZAyYTWXTkvKQN5GrzCmfON2l2x9lixV6r1LwEU5G1M9PKrIlEDVy5HDJUvXxJhKG4iAhPGuy3OSUQ4CJWM1kSu4VVmNkghFArx5ffnom4S562Bi2eVTco4XpbJ0ws-3D




More information about the coreboot mailing list