[coreboot] New Defects reported by Coverity Scan for coreboot

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan.

1 new defect(s) introduced to coreboot found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1380991:  Code maintainability issues  (UNUSED_VALUE)
/3rdparty/vboot/firmware/lib/vboot_ui_menu.c: 1114 in vb2_recovery_menu()


________________________________________________________________________________________________________
*** CID 1380991:  Code maintainability issues  (UNUSED_VALUE)
/3rdparty/vboot/firmware/lib/vboot_ui_menu.c: 1114 in vb2_recovery_menu()
1108     				break;
1109     			case VB_BUTTON_VOL_UP:
1110     			case VB_BUTTON_VOL_DOWN:
1111     			case VB_KEY_UP:
1112     			case VB_KEY_DOWN:
1113     				if (current_menu == VB_MENU_RECOVERY_INSERT) {
>>>     CID 1380991:  Code maintainability issues  (UNUSED_VALUE)
>>>     Assigning value from "vb2_update_menu(ctx)" to "ret" here, but that stored value is overwritten before it can be used.
1114     					ret = vb2_update_menu(ctx);
1115     					vb2_set_disabled_idx_mask(shared->flags);
1116     				} else {
1117     					vb2_update_selection(cparams, key);
1118     				}
1119     				vb2_draw_current_screen(ctx, cparams);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbLuoVetFLSjdonCi1EjfHRqWGQvojmmkYaBE-2BPJiTQvQ-3D-3D_q4bX76XMySz3BXBlWr5fXXJ4cvAsgEXEqC7dBPM7O5bitsdhFsrGyJ-2BxOj3NN-2BP6QLFjCZ4bgAytyK5IHIHeJgRYqAReTeLLp1C-2BRvwCXb2CJFNU2GS5H4R2nMT0pHIVajXbzAlMSA0b5Hy8x2cC-2FSonjHpXOW4z4wrgou3ln9-2BZ8jQztyKGXhYmtuWqy6IliNEdpS5ZBmpSvS8zy0F74b5hhI7Dd-2FC-2FRCSgM-2Fo191M-3D

To manage Coverity Scan email notifications for "coreboot at coreboot.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4e-2BpBzwOa5gzBZa9dWpDbzfofODnVj1enK2UkK0-2BgCCqfkfgGF5ECMwHI0-2FVznrU953Dvw3Ddjop950pccFQ-2Br0qaXkQSgAjbZsF6g7Yem3Y-3D_q4bX76XMySz3BXBlWr5fXXJ4cvAsgEXEqC7dBPM7O5bitsdhFsrGyJ-2BxOj3NN-2BP656-2FfgUfBQTsPdRY9O8A1HI86V3TBDdYAQPCYeYquDAA0VWdaRBgqW0ysfEBO6-2BRFj-2FGQwijV93IGpEIkwXQt06NCK7SM3LyWUyaWFS-2F9LTsp0OqO-2BmZ4HU2roY-2Btcqk3h31AVIULqYOrVjgQSMpFT5CTecBNPwtvtRYbKUCq-2Blg-3D