[coreboot] QA: Properly relay results of `checkpatch.pl` check

Paul Menzel paulepanter at users.sourceforge.net
Thu Feb 23 22:16:57 CET 2017


Dear coreboot folks,


Each commit pushed to Gerrit is automatically tested for “formal”
issues by using `checkpatch.pl`. See for example [1].

Though despite missing a space violating our coding style, which is
also found by `checkpatch.pl` [2], the comment contains, that no errors
is found.

> https://qa.coreboot.org/job/coreboot-checkpatch/5142/ : SUCCESS

```
ERROR: space required before the open brace '{'
#49: FILE: src/mainboard/google/gru/pwm_regulator.c:61:
+	} else if (IS_ENABLED(CONFIG_BOARD_GOOGLE_KEVIN) && board_id() >= 6){

total: 1 errors, 0 warnings, 49 lines checked
```

Is there a reason for not relaying these errors?

If not, it’d be great to do so (and for the Chromium and Intel folks to
also do that in their repository).


Thanks,

Paul


[1] https://review.coreboot.org/18460
[2] https://qa.coreboot.org/job/coreboot-checkpatch/5142/console
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: This is a digitally signed message part
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20170223/c6942119/attachment.asc>


More information about the coreboot mailing list