[coreboot] `DEBUG_INTEL_ME` (incorrectly) only selected for Intel BD82x6x

mrnuke mr.nuke.me at gmail.com
Wed Feb 26 04:24:50 CET 2014

On Wednesday, February 19, 2014 11:06:40 PM Paul Menzel wrote:
> looking through `src/console/Kconfig` I noticed
You mean 'src/Kconfig' ?

This is a layering violation. We shouldn't have hardware-specific options in 
top-level Kconfig. This should be moved to southbridge Kconfig, and not depend 
on LOGLEVEL. Maybe we need to move ME handling to a common dir and handle the 
Kconfigs there.

> which seems odd as currently other chipsets needing the Intel Management
> Engine were submitted.
>         $ git grep DEBUG_INTEL_ME
>         [...]
Smells like copypasta. Yet another reason to consider unifying ME handling 
across southbridges.

> I am unable to test this, so it would be great if somebody else could
> fix this.
I don't blame you for not owning and/or not wanting to own intel hardware.


More information about the coreboot mailing list