[coreboot] New patch to review for coreboot: 13e1b9f rmodule: add 16 bytes of padding

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Fri Mar 15 20:49:48 CET 2013

Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2749


commit 13e1b9f5219d48978c19372a63ef0da8b8321df0
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Wed Feb 6 12:47:26 2013 -0600

    rmodule: add 16 bytes of padding
    There is a plan to utlize rmodules for loading ramstage as a
    relocatable module. However, the rmodule header may change.
    In order to provide some wiggle room for changing the contents
    of the rmodule header add some padding. This won't stop the need
    for coordinating properly between the romstage loader that may be
    in readonly flash and rmodule header fields.  But it will provide
    for a way to make certain assumptions about alignment of the
    rmodule's program when the rmodule is compressed in the flash.
    Change-Id: I9ac5cf495c0bce494e7eaa3bd2f2bd39889b4c52
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
 src/include/rmodule.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/include/rmodule.h b/src/include/rmodule.h
index b51700c..c81ec17 100644
--- a/src/include/rmodule.h
+++ b/src/include/rmodule.h
@@ -100,6 +100,8 @@ struct rmodule_header {
 	/* BSS section information so the loader can clear the bss. */
 	u32 bss_begin;
 	u32 bss_end;
+	/* Add some room for growth. */
+	u32 padding[4];
 } __attribute__ ((packed));
 struct rmodule {

More information about the coreboot mailing list