[coreboot] New patch to review for coreboot: 3ff84d3 ACPI: remove empty get_cst_entries()

Sven Schnelle (svens@stackframe.org) gerrit at coreboot.org
Fri Dec 23 11:27:19 CET 2011


Sven Schnelle (svens at stackframe.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/496

-gerrit

commit 3ff84d326ee881a4ec2f3995744363d75710cf14
Author: Sven Schnelle <svens at stackframe.org>
Date:   Fri Dec 23 10:29:09 2011 +0100

    ACPI: remove empty get_cst_entries()
    
    This function prevents the linker from choosing the right
    get_cst_entries(), preventing writing the _CST tables.
    
    Change-Id: I4bc0168aee110171faeaa081f217dfd1536bb821
    Signed-off-by: Sven Schnelle <svens at stackframe.org>
---
 src/cpu/intel/speedstep/acpi.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/src/cpu/intel/speedstep/acpi.c b/src/cpu/intel/speedstep/acpi.c
index 8f32e4f..c7ad4f6 100644
--- a/src/cpu/intel/speedstep/acpi.c
+++ b/src/cpu/intel/speedstep/acpi.c
@@ -62,11 +62,6 @@ static int get_fsb(void)
 	return 200;
 }
 
-int get_cst_entries(struct cst_entry **entries __attribute__((unused)))
-{
-	return 0;
-}
-
 void generate_cpu_entries(void)
 {
 	int len_pr, len_ps;
@@ -89,7 +84,7 @@ void generate_cpu_entries(void)
 		len_pr = acpigen_write_processor((cpuID-1)*cores_per_package+coreID-1, pcontrol_blk, plen);
 			len_pr += acpigen_write_empty_PCT();
 			len_pr += acpigen_write_PSD_package(cpuID-1,cores_per_package,SW_ANY);
-			if ((count = get_cst_entries(&cst_entries)) > 0)
+			if (get_cst_entries && (count = get_cst_entries(&cst_entries)) > 0)
 				len_pr += acpigen_write_CST_package(cst_entries, count);
 			len_pr += acpigen_write_name("_PSS");
 




More information about the coreboot mailing list