[coreboot] [PATCH] superiotool.h: Add `EOT` to end of entry

Paul Menzel paulepanter at users.sourceforge.net
Tue Dec 20 21:13:21 CET 2011

Date: Mon, 19 Dec 2011 23:50:32 +0100

This is a fix up for commit 3d1d6bb4 which forgot to add `EOT` at the end.

        commit 3d1d6bb4ecb15a12f48f871c623882bee9c0c576
        Author: Jonathan A. Kollasch <jakllsch at kollasch.net>
        Date:   Mon Nov 7 10:56:42 2011 -0600

            superiotool: add detection and dump of Infineon SLB9635 TPM

Carl-Daniel explained the continuous integration tool Jenkins did not
catch that, since this is a run time bug. It accesses uninitialized
memory until it crashes and writes random data to random I/O locations.

Reported-by (on IRC): Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
 util/superiotool/superiotool.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/util/superiotool/superiotool.h b/util/superiotool/superiotool.h
index 5583ec5..94918b8 100644
--- a/util/superiotool/superiotool.h
+++ b/util/superiotool/superiotool.h
@@ -247,7 +247,7 @@ static const struct {
 	{probe_idregs_amd,	{0xaa, EOT}},
 	{probe_idregs_serverengines,	{0x2e, EOT}},
-	{probe_idregs_infineon,	{0x2e, 0x4e}},
+	{probe_idregs_infineon,	{0x2e, 0x4e, EOT}},
 /** Table of functions to print out supported Super I/O chips. */
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20111220/e20388ac/attachment.sig>

More information about the coreboot mailing list