[coreboot] [commit] r5594 - in trunk/src: devices/oprom/yabel northbridge/intel/i82830 southbridge/intel/i82801dx

repository service svn at coreboot.org
Thu May 27 17:41:16 CEST 2010


Author: stepan
Date: Thu May 27 17:41:15 2010
New Revision: 5594
URL: https://tracker.coreboot.org/trac/coreboot/changeset/5594

Log:
fix warnings.
Signed-off-by: Stefan Reinauer <stepan at coresystems.de>
Acked-by: Stefan Reinauer <stepan at coresystems.de>

Modified:
   trunk/src/devices/oprom/yabel/device.c
   trunk/src/northbridge/intel/i82830/i82830_smihandler.c
   trunk/src/southbridge/intel/i82801dx/i82801dx_smihandler.c

Modified: trunk/src/devices/oprom/yabel/device.c
==============================================================================
--- trunk/src/devices/oprom/yabel/device.c	Wed May 26 19:08:13 2010	(r5593)
+++ trunk/src/devices/oprom/yabel/device.c	Thu May 27 17:41:15 2010	(r5594)
@@ -44,7 +44,6 @@
 biosemu_dev_get_addr_info(void)
 {
 	int taa_index = 0;
-	int i = 0;
 	struct resource *r;
 	u8 bus = bios_device.dev->bus->link;
 	u16 devfn = bios_device.dev->path.pci.devfn;
@@ -115,6 +114,7 @@
 	//dump translate_address_array
 	printf("translate_address_array: \n");
 	translate_address_t ta;
+	int i;
 	for (i = 0; i <= taa_last_entry; i++) {
 		ta = translate_address_array[i];
 		printf

Modified: trunk/src/northbridge/intel/i82830/i82830_smihandler.c
==============================================================================
--- trunk/src/northbridge/intel/i82830/i82830_smihandler.c	Wed May 26 19:08:13 2010	(r5593)
+++ trunk/src/northbridge/intel/i82830/i82830_smihandler.c	Thu May 27 17:41:15 2010	(r5594)
@@ -217,7 +217,7 @@
 					printk(BIOS_DEBUG, "%c",  mbi_header->name[j]);
 				printk(BIOS_DEBUG, "' found.\n");
 #ifdef DEBUG_SMI_I82830
-				dump(banner_id, sizeof(obj_header_t) + 16);
+				dump((u8 *)banner_id, sizeof(obj_header_t) + ALIGN(mbi_header->name_len, 16));
 #endif
 				break;
 			}
@@ -233,7 +233,7 @@
 		mbi_header_t *mbi_header = NULL;
 		printk(BIOS_DEBUG, "|- MBI_GetObject\n");
 #ifdef DEBUG_SMI_I82830
-		printk(BIOS_DEBUG, "|  |- handle = %016lx\n", getobj->handle);
+		printk(BIOS_DEBUG, "|  |- handle = %016Lx\n", getobj->handle);
 #endif
 		printk(BIOS_DEBUG, "|  |- objnum = %d\n", getobj->objnum);
 		printk(BIOS_DEBUG, "|  |- start = %x\n", getobj->start);
@@ -262,8 +262,8 @@
 
 				getobj->banner.retsts = MSH_OK;
 #ifdef DEBUG_SMI_I82830
-				dump(banner_id, sizeof(*getobj));
-				dump(getobj->buffer + OBJ_OFFSET, len);
+				dump((u8 *)banner_id, sizeof(*getobj));
+				dump((u8 *)getobj->buffer + OBJ_OFFSET, len);
 #endif
 				break;
 			}

Modified: trunk/src/southbridge/intel/i82801dx/i82801dx_smihandler.c
==============================================================================
--- trunk/src/southbridge/intel/i82801dx/i82801dx_smihandler.c	Wed May 26 19:08:13 2010	(r5593)
+++ trunk/src/southbridge/intel/i82801dx/i82801dx_smihandler.c	Thu May 27 17:41:15 2010	(r5594)
@@ -449,8 +449,6 @@
 	dump_gpe0_status(gpe0_sts);
 }
 
-void __attribute__((weak)) mainboard_smi_gpi(u16 gpi_sts);
-
 static void southbridge_smi_gpi(unsigned int node, smm_state_save_area_t *state_save)
 {
 	u16 reg16;




More information about the coreboot mailing list