[coreboot] [PATCH] Wyse S50 cleanup

Nils njacobs8 at hetnet.nl
Wed May 12 21:44:13 CEST 2010

This patch cleanes up the Wyse S50 port and unifies the memmory regions
with Geode LX , adds gpl2 headers plus some white space fixes.

This is build and boot tested.(of course vsa loading is stil not fixed,it now
runs forever with :"Oops, exception 13 while executing option rom")

Signed-off-by: Nils Jacobs <njacobs8 at hetnet.nl>

Hi Patrick,
Thanks for the review!

Op woensdag 12 mei 2010 12:49:47 schreef u:
>In Kconfig:
>+## the Free Software Foundation; either version 2 of the License, or
>+## (at your option) any later version.
>We usually use exactly version 2, not 2 plus whatever the FSF might come
>up with in future. The other files already use the "version 2 only" verbage.
I am sorry about that mistake, i copied it from AMD Rumba.
Attached you find a corrected v2 version of the patch.

I looked a little at the current trunk and found a "few" other kconfig`s that 
had the "wrong" GPLv2 header.
I hope everybody knows this new rule because the last wrong one
is committed two weeks ago!

I think often new patches are copied out of trunk.
To stop the chance of copying the wrong version, i prepared a little patch
for you.(see attachment 2)
>+config RAMBASE
>+       hex
>+       default 0x4000
>+       depends on BOARD_WYSE_S50
>Is that necessary? If so, we should fix the reason. RAMBASE below 1MB is
>going to go away as soon as the remaining issues are fixed.
This is necessary in rev5542, otherwise the board hangs after ramtest.
See attached log.I didn`t test it with rev5543(the new revisions come faster 
than i can test).  :)
So i think this is one of the remaining issues.
>Everything else is
>Acked-by: Patrick Georgi <patrick.georgi at coresystems.de>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 5543_s50_cleanup2.patch
Type: text/x-patch
Size: 11519 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100512/239bcf2b/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 5543_kconfig_gplv2.patch
Type: text/x-patch
Size: 47800 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100512/239bcf2b/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: coreboot157.log
Type: text/x-log
Size: 298 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100512/239bcf2b/attachment.log>

More information about the coreboot mailing list