[coreboot] [PATCH]Include headers instead of sources in romstage, part 2/many

Stefan Reinauer stefan.reinauer at coresystems.de
Sun May 9 23:08:14 CEST 2010


On 5/8/10 11:48 PM, Patrick Georgi wrote:
> Am 08.05.2010 23:40, schrieb Stefan Reinauer:
>   
>> On 5/8/10 10:59 PM, Patrick Georgi wrote:
>>     
>>> Index: src/include/lib.h
>>> ===================================================================
>>> --- src/include/lib.h	(Revision 5532)
>>> +++ src/include/lib.h	(Arbeitskopie)
>>> @@ -49,5 +49,7 @@
>>>  void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx);
>>>  #endif
>>>  
>>> +#else /* __ROMCC__ */
>>> +#include "pc80/serial.c"
>>>  #endif /* __ROMCC__ */
>>>  #endif /* __LIB_H__ */
>>>   
>>>       
>> It looks like only console/console.h is actually using these functions,
>> so I think it should rather be included in console/console.h than in lib.h?
>>     
> Oops, that was the older version of the patch (this won't even compile
> on all boards)
>
> See attached patch instead
>
> Signed-off-by: Patrick Georgi <patrick.georgi at coresystems.de>
>   
Acked-by: Stefan Reinauer <stepan at coresystems.de>

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866





More information about the coreboot mailing list