[coreboot] [PATCH]Include headers instead of sources in romstage, part 2/many

Patrick Georgi patrick at georgi-clan.de
Sat May 8 23:48:30 CEST 2010


Am 08.05.2010 23:40, schrieb Stefan Reinauer:
> On 5/8/10 10:59 PM, Patrick Georgi wrote:
>> Index: src/include/lib.h
>> ===================================================================
>> --- src/include/lib.h	(Revision 5532)
>> +++ src/include/lib.h	(Arbeitskopie)
>> @@ -49,5 +49,7 @@
>>  void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx);
>>  #endif
>>  
>> +#else /* __ROMCC__ */
>> +#include "pc80/serial.c"
>>  #endif /* __ROMCC__ */
>>  #endif /* __LIB_H__ */
>>   
> It looks like only console/console.h is actually using these functions,
> so I think it should rather be included in console/console.h than in lib.h?
Oops, that was the older version of the patch (this won't even compile
on all boards)

See attached patch instead

Signed-off-by: Patrick Georgi <patrick.georgi at coresystems.de>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 20100508-2-remove-serial.c-includes.diff
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100508/e3503c4f/attachment.ksh>


More information about the coreboot mailing list